Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Update] API version edited autoscaling/v2beta -> autoscaling/v2 in line 5797, serving-core.yaml #2477

Closed
wants to merge 1 commit into from
Closed

[Update] API version edited autoscaling/v2beta -> autoscaling/v2 in line 5797, serving-core.yaml #2477

wants to merge 1 commit into from

Conversation

chromatices
Copy link

Which issue is resolved by this Pull Request:#2476
Resolves #

Description of your changes:
change APIversion in ./common/knative/knative-serving/base/upstream/serving-core.yaml at line 5797

Checklist:

  • Unit tests pass:
    Make sure you have installed kustomize == 3.2.1
    1. make generate-changed-only
    2. make test

@google-cla
Copy link

google-cla bot commented Jul 12, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chromatices
Once this PR has been reviewed and has the lgtm label, please assign krishnadurai for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@annajung
Copy link
Member

Hi, can you please sign the CLA. Only the PRs with valid CLA are reviewed, thanks!

@chromatices
Copy link
Author

Sorry, i checked and updated my CLA immediately.

@annajung
Copy link
Member

Thanks for the contribution! But, since the update to Knative version #2486, this PR no longer is needed. If you still see an issue in current version after rebasing, feel free to re-open.

/close

@google-oss-prow google-oss-prow bot closed this Aug 10, 2023
@google-oss-prow
Copy link

@annajung: Closed this PR.

In response to this:

Thanks for the contribution! But, since the update to Knative version #2486, this PR no longer is needed. If you still see an issue in current version after rebasing, feel free to re-open.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrian555 adrian555 Awaiting requested review from adrian555

@annajung annajung Awaiting requested review from annajung

@yuzisun yuzisun Awaiting requested review from yuzisun

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chromatices @annajung